refactor(ai-logic): simplify samples categories#2791
Conversation
…rpf/refactor-categories # Conflicts: # firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/ui/navigation/FirebaseAISamples.kt
…rpf/refactor-categories # Conflicts: # firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/ui/navigation/FirebaseAISamples.kt # firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/ui/navigation/Sample.kt
Keeps it Simple :)
…rpf/refactor-categories
…rpf/refactor-categories
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reorganizes the sample application by updating model versions to Gemini 3.1, 3.5, and 3 Pro, rebranding image features under the "Nano Banana" name, and restructuring navigation categories. UI enhancements were made to the MainMenuScreen, and SvgViewModel now includes logic to strip markdown from responses. Feedback points out an unused Log import and dead code in the navigation parameters. Additionally, suggestions were made to fix the alignment of filter chips and to implement a more robust method for cleaning SVG strings.
| } | ||
| } | ||
| Text( | ||
| text = "Samples", |
There was a problem hiding this comment.
Do we keep Strings hardcoded in the screen for the quick start samples? If not - recommend moving all hardcoded strings in the compose files to the xml file.
There was a problem hiding this comment.
I don't have a strong preference.
Btw, this line was deleted, so we technically need this particular string.
marinacoelho
left a comment
marinacoelho
left a comment
There was a problem hiding this comment.
Just one comment about strings - LGTM.
2 participants
This PR should:
Preview